perf: cache swizzled selector construction #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Eduardo Speroni <edusperoni@users.noreply.github.com>
NathanWalker
pushed a commit
that referenced
this pull request
Jul 22, 2022
caitp
pushed a commit
to caitp/ns-v8ios-runtime
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if a swizzled method exists constructs the selector for every call by concatenating the swizzle prefix to the actual selector string. This is pretty slow when doing many calls.
This PR keeps a map (using robin_hood::unordered_map for performance) of SEL (selector) pairs, so that the swizzled selector is only constructed once, and any subsequent calls will use the fast-path by returning the value from the cache.
From a few performance tests, we've seen a ~30% improvement, though it may vary from case to case.